Skip to content

Conversation

@Kourin1996
Copy link

@Kourin1996 Kourin1996 commented Jul 11, 2025

This PR adds optional intents to deploy Celo custom gas token on L1 and CELO-specific L2 contracts, enabling Kurtosis devnet to run on celo-rebase-13

These flags are enabled through the intent shown in the following code:
https://github.com/celo-org/optimism-package/blob/3d50e7f2503b26f782c134aaa1c649088a83511a/src/contracts/contract_deployer.star#L201-L206

Address https://github.com/celo-org/celo-blockchain-planning/issues/893, https://github.com/celo-org/celo-blockchain-planning/issues/894

@Kourin1996 Kourin1996 self-assigned this Jul 11, 2025
@Kourin1996 Kourin1996 marked this pull request as ready for review July 11, 2025 09:31
@Kourin1996 Kourin1996 requested review from pahor167 and palango July 11, 2025 09:33
@pahor167
Copy link

Overall changes look good

One thing that I'm missing is CeloSuperchainConfig (I'm not sure how much aligned with mainnet do you want to be).

We currently chose different approach with introducing CustomGasToken and CeloSuperchainConfig for Celo Sepolia Testnet - https://github.com/celo-org/optimism/commits/pahor/newTestnetDeploy (you can check few last commits that are specifically addressing this)

@Kourin1996 Kourin1996 force-pushed the Kourin1996/celo-rebase-13-contracts-devnet branch from 0058e4a to f8aeb37 Compare July 17, 2025 07:36
@Kourin1996 Kourin1996 changed the base branch from celo-contracts/v3.0.0--1 to pahor/newTestnetDeploy July 17, 2025 07:37
@Kourin1996
Copy link
Author

@pahor167 Hi, I adjusted my code for new version of op-deployer and switched the target branch to pahor/newTestnetDeploy. My change should not affect to normal deployment without new overrides.

I would be appreciate if you could check it at your convenience. Thank you!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say something specific -> but I would compare this file with the one from martinvol/completeMigrations: https://github.com/celo-org/optimism/blob/martinvol/completeMigrations/packages/contracts-bedrock/scripts/L2Genesis.s.sol

And discuss potential differences with @martinvol -> since this one is the base for changes in Migration.s.sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants